fix: include start/end time when validating availability window#716
Open
fix: include start/end time when validating availability window#716
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
adeiji
force-pushed
the
fix/scheduled-event-end-date
branch
from
1f797c7 to
c3b8fcf
Compare
sricharan-varanasi
requested changes
Apr 7, 2026
Contributor
sricharan-varanasi
left a comment
sricharan-varanasi
left a comment
There was a problem hiding this comment.
Looks good, Ade.
Can we add tests for this case?
|
|
||
| public isInsideValidDatesInterval(event: ScheduleEvent) { | ||
| const { startDate, endDate } = event.availability; | ||
| const { timeFrom, timeTo } = event.availability; |
Contributor
There was a problem hiding this comment.
nit: can we do a single destructure instead of two?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-8773
Fixed a bug where scheduled events were not showing on the end date. For example, if the scheduled event's end date was April 1, 2026 @ 11:59 PM and on April 1, 2026 @ 5 PM the user is viewing available events, the event would not show up. Now, when viewing the event on the last day:
🪤 Peer Testing
Expected Outcome: The event should be visible
Expected outcome: The event should not be visible
✏️ Notes
Validation was comparing only the date component and ignoring the time component.