Pair AiArrayMapConst with AiArrayUnmapConst in prim writer#2660
Merged
Conversation
UsdArnoldPrimWriter::_WriteArnoldParameters mapped array data with AiArrayMapConst but unmapped seven of the type branches with the non-const AiArrayUnmap (AI_TYPE_BYTE, BOOLEAN, RGB, VECTOR, RGBA, VECTOR2, MATRIX). The remaining type branches already used the const variant. Mismatching the const/non-const map+unmap pair flags the array as modified even though it was only read, which can trigger spurious copies / writebacks.
sebastienblor
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UsdArnoldPrimWriter::_WriteArnoldParameters, the per-type branches read array data viaAiArrayMapConst(array)but seven branches unmapped it with the non-constAiArrayUnmap(array):AI_TYPE_BYTE,AI_TYPE_BOOLEAN,AI_TYPE_RGB,AI_TYPE_VECTOR,AI_TYPE_RGBA,AI_TYPE_VECTOR2,AI_TYPE_MATRIX.AI_TYPE_INT,AI_TYPE_UINT,AI_TYPE_FLOAT) already used the matchingAiArrayUnmapConst.AiArrayUnmapConst. The only remaining non-constAiArrayMap/AiArrayUnmappair in the file (theshidxswrite site) is unchanged.Test plan