Adds "Icon Spacing" to the user preferences alongside a hard toggle t…#151
Open
verikono wants to merge 1 commit intozquestz:masterfrom
Open
Adds "Icon Spacing" to the user preferences alongside a hard toggle t…#151verikono wants to merge 1 commit intozquestz:masterfrom
verikono wants to merge 1 commit intozquestz:masterfrom
Conversation
…o defer to the theme padding property. I also hit a few segfaults so added a mechanism to lib/PositionManager.vala which accounts for things like the controller not having any visible items (divide by zero) : deserves some review prior to PR acceptence
Owner
|
If we go this route wouldn't it be better to offer a theme tab and allow the user to override all theme values? |
Author
|
Sounds good to me. There's a clear separation in the code between theme and settings which I put an axe through the side of, so pulling back and splitting to two tabs works much cleaner for me. I'll look into it tomorrow. V. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shouldn't be considered final and is just to let you be aware that I'm rolling up some additions.
Users can now access icon spacing from the preferences screen as a sliding value of 0.1-20. It felt like its a variable that shouldn't require opening up the theme.
Users can force a use of the theme's item.padding via a toggle in the preferences screen. not sure if this is needed but it lets the user declare without any ambiguity that they want the theme's value.
I also added some eval code which avoids divide-by-zero possibilities. Happy to follow any direction you want to issue.
V.