Crossref Unixref XML: Remove space in abstractNotes#3597
Open
northword wants to merge 2 commits intozotero:masterfrom
Open
Crossref Unixref XML: Remove space in abstractNotes#3597northword wants to merge 2 commits intozotero:masterfrom
northword wants to merge 2 commits intozotero:masterfrom
Conversation
1 task
Contributor
Author
|
The CI error seems unrelated to this PR change. Please ping me if any modifications are needed. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sometimes, the summary may include space indentation, such as
10.1039/D5GC06007A, and the API returns the result as:Before this change
The previous translator converted it to:
This is ugly and hard to read.
And, these spaces will also look quite messy when exported to XML, see ref: northword/zotero-format-metadata#404, of course, this is an issue with "exporting" not with translators.
After this change
Looks better.
Additional Note
This item will return two
abstract, one is the TOC abstract and the other is the main abstract. I think it would be better to save both, but we need a line break (even two) to distinguish them.Since we use
ZU.trimInternalto remove extra spaces, I had to set a delimiter<!-- mutil-part -->to mark the split between the two abstract.