Open
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Collaborator
|
Thanks for the PR. I will take a closer look on this on the weekend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a public
XSubSocketimplementation to match the existingSocketType::XSUBsupport.The implementation supports bind/connect, recv/send, subscribe/unsubscribe, and reconnect with subscription replay. As part of this, the shared subscription and reconnect logic used by
SUBandXSUBis moved into a common backend while keepingSubSocketbehavior unchanged. Subscription state is stored as raw bytes so non-UTF8 subscriptions are preserved correctly across unsubscribe and reconnect replay.The change also adds coverage for basic
XSUB <-> XPUBbehavior, arbitraryXSUB -> XPUBsends, fanout, reconnect, proxying, and minimal cross-implementation tests againstlibzmq.This should address #40.