Conversation
New conformance tests that verify wire protocol compatibility with libzmq: - router_dealer_compliant.rs: Tests ROUTER/DEALER identity-based routing - Our ROUTER ↔ their DEALER (3 tests including multi-client) - Our DEALER ↔ their ROUTER - pub_sub_compliant_reverse.rs: Tests our PUB with their SUB - Broadcast delivery to multiple subscribers - Topic filtering with different subscription patterns - reconnection_compliant.rs: Tests reconnection behavior (currently ignored) - Reveals that subscription resync after peer restart isn't fully implemented - Documented as known limitation for future work Total: 7 new tests (5 passing, 2 ignored)
- Add backticks around file reference in doc comment - Combine duplicate match arms for recv_string error handling - Add #[allow(dead_code)] to compliance helpers used by subset of tests - Apply cargo fmt formatting fixes
- Remove Pipe trait helper that was after test module - Remove unnecessary borrow in send_multipart call - Apply cargo fmt to all test files
- Wrap URL in angle brackets for doc_markdown lint - Replace redundant continue with empty match arm - Convert loop/match to while let loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 229 is my favorite prime number! 🎉
Summary
Adds more conformance tests that verify wire protocol compatibility between zmq.rs and the reference libzmq implementation.
Tests Added
All tests pass except 2 ignored tests that reveal known limitations for future work.