Add compatibility with Zarr-Python 3.2.0#957
Add compatibility with Zarr-Python 3.2.0#957maxrjones wants to merge 3 commits intozarr-developers:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #957 +/- ##
==========================================
+ Coverage 89.30% 89.34% +0.03%
==========================================
Files 33 33
Lines 2039 2046 +7
==========================================
+ Hits 1821 1828 +7
Misses 218 218
🚀 New features to boost your workflow:
|
|
failures should be fixed upstream by earth-mover/icechunk#1937 |
Note that this is only for Icechunk 2.0. We actually have the same problem for the latest release of IC 1.0 . But do we care about that? |
|
Also can we perhaps release a patch version of VZ first? We have multiple things going on here:
|
I think that any release of Icechunk with a fix for the missing readme would solve our CI problems, as long as we don't pin to <2. |
I'd support merging and releasing #952 before any other changes. fwiw I don't think it's bad to have merged #897 before the patch release - that's a long overdue bug fix. |
That release should come in a sec / by tomorrow.
Agreed. |
TomNicholas
left a comment
There was a problem hiding this comment.
Released, so as long as this passes (particularly on min-deps!) then lets go
| try: | ||
| from zarr.core.metadata.v3 import RegularChunkGridMetadata # zarr-python>3.1.6 | ||
| except ImportError: | ||
| from zarr.core.metadata.v3 import ( | ||
| RegularChunkGrid as RegularChunkGridMetadata, # zarr-python<=3.1.6 | ||
| ) |
There was a problem hiding this comment.
Maybe we should actually look for specific versions of zarr-python instead of the blind try...except?
There are some internal changes coming in Zarr-Python that impact VirtualiZarr, which are addressed by this PR.
Acceptance criteria:
docs/releases.md*.mdfile underdocs/api