Open
Conversation
Due to DATA_ PRODUCTS is a list, and when in a for loop, as long as there is one successful download, it can be assumed that it does not necessarily have to be downloaded successfully all three times. Therefore, throwing exceptions in the for loop is unscientific. I downloaded the data using this method successfully in the second round, but failed in the third round. The data can be downloaded locally, but there is a prompt of None of the archived ids succeeded! Update necessary Therefore, it is recommended to modify according to the above method. The caller can also determine whether the data download was successful by checking if the file name is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to DATA_ PRODUCTS is a list, and when in a for loop, as long as there is one successful download, it can be assumed that it does not necessarily have to be downloaded successfully all three times. Therefore, throwing exceptions in the for loop is unscientific. I downloaded the data using this method successfully in the second round, but failed in the third round. The data can be downloaded locally, but there is a prompt of None of the archived ids succeeded! Update necessary Therefore, it is recommended to modify according to the above method. The caller can also determine whether the data download was successful by checking if the file name is empty.