Fix: normalize absolute image paths in composition loading#409
Open
oiesc wants to merge 1 commit intoxvrh:masterfrom
Open
Fix: normalize absolute image paths in composition loading#409oiesc wants to merge 1 commit intoxvrh:masterfrom
oiesc wants to merge 1 commit intoxvrh:masterfrom
Conversation
This PR fixes an issue where image paths inside the composition could start with a leading slash (/), causing them not to match entries in the archive. Expected: images/bg.png Got: /images/bg.png As a result, the image wasn’t found and failed to load. We now check if the joined path is absolute using p.posix.isAbsolute(imagePath) and remove the leading slash when needed:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where image paths inside the composition could start with a leading slash (/), causing them not to match entries in the archive.
As a result, the image wasn’t found and failed to load.
We now check if the joined path is absolute using p.posix.isAbsolute(imagePath) and remove the leading slash when needed: