Skip to content

Batch-settlement: go-ts parity#2227

Merged
CarsonRoscoe merged 6 commits intox402-foundation:feat/batch-settlement-go-sdkfrom
phdargen:batch-settlement-go-ts-parity
May 8, 2026
Merged

Batch-settlement: go-ts parity#2227
CarsonRoscoe merged 6 commits intox402-foundation:feat/batch-settlement-go-sdkfrom
phdargen:batch-settlement-go-ts-parity

Conversation

@phdargen
Copy link
Copy Markdown
Collaborator

@phdargen phdargen commented May 7, 2026

Description

commit 4cfb896:

  • After a full cooperative refund, the server-side channel file should be deleted, and after a successful paid request the pendingRequest should be cleared
  • Request context identity breaks when payload is enriched => implemented deterministic key built only from immutable request fields
  • Added missing pendingRequest cleanup on failures: OnVerifyFailureHook() and OnSettleFailureHook() clean up

commit 691decb:

  • fixed lint

commit 40facfa:

  • removed duplicate payer info from storage

commit e300927:

  • fixed PAYMENT-RESPONSE field ordering

commit 64d20cf:

  • cleaned up comments removing TS implementation references

commit 9417394:

  • consolidated ProcessSettlementWithExtensions into ProcessSettlement

Checklist

  • I have formatted and linted my code
  • All new and existing tests pass
  • My commits are signed (required for merge) -- you may need to rebase if you initially pushed unsigned commits
  • I added a changelog fragment for user-facing changes (docs-only changes can skip)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

@phdargen is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added go sdk Changes to core v2 packages examples Changes to examples labels May 7, 2026
@phdargen phdargen marked this pull request as draft May 7, 2026 17:21
@phdargen phdargen changed the title fix PendingRequest and refund cleanup Batch-settlement: go-ts parity May 7, 2026
@phdargen phdargen marked this pull request as ready for review May 7, 2026 19:29
@phdargen phdargen force-pushed the batch-settlement-go-ts-parity branch from 64d20cf to f5a993a Compare May 7, 2026 20:03
@CarsonRoscoe CarsonRoscoe merged commit 5b79c3e into x402-foundation:feat/batch-settlement-go-sdk May 8, 2026
14 of 15 checks passed
Must-be-Ash pushed a commit that referenced this pull request May 8, 2026
* feat: add batch-settlement implementation to Go SDK

* feat: add batch-settlement examples for go sdk

* feat: updated typescript examples to match go examples

* feat: add e2e testing for batch-settlement in go

* Batch-settlement: go-ts parity (#2227)

* fix PendingRequest and refund cleanup

* fix lint

* remove duplicate payer info from storage

* fix PAYMENT-RESPONSE field ordering

* clean up comments

* consolidate ProcessSettlementWithExtensions into ProcessSettlement

---------

Co-authored-by: phdargen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples Changes to examples go sdk Changes to core v2 packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants