Skip to content

Removed mysql 5.7 from tested dbms#6060

Merged
himeshsiriwardana merged 1 commit intowso2:masterfrom
himeshsiriwardana:remove-mssql-5.7
Apr 12, 2026
Merged

Removed mysql 5.7 from tested dbms#6060
himeshsiriwardana merged 1 commit intowso2:masterfrom
himeshsiriwardana:remove-mssql-5.7

Conversation

@himeshsiriwardana
Copy link
Copy Markdown
Contributor

Purpose

$subject

Related PRs

Test environment

Security checks

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 11, 2026

📝 Walkthrough

Walkthrough

Updated product compatibility documentation across version branches by removing MySQL 5.7 from the tested database management system versions, retaining only MySQL 8.4 and 8.0 support.

Changes

Cohort / File(s) Summary
MySQL Compatibility Updates
en/identity-server/7.2.0/docs/deploy/product-compatibility.md, en/identity-server/next/docs/deploy/product-compatibility.md
Removed MySQL version 5.7 from the tested DBMS compatibility table, leaving only versions 8.4 and 8.0.

Suggested labels

Team/Identity Server Core

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete; the Purpose section contains only a placeholder ($subject) instead of actual explanation, and Test environment and Related PRs sections are empty. Replace the $subject placeholder with a clear explanation of why MySQL 5.7 was removed, and fill in the Test environment section with relevant details.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change—removing MySQL 5.7 from tested DBMS versions in the compatibility documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
en/identity-server/7.2.0/docs/deploy/product-compatibility.md (1)

5-5: ⚠️ Potential issue | 🟠 Major

Fix trailing whitespace to unblock Markdown lint.

Line 5 has a trailing space, which matches the reported MD009/no-trailing-spaces pipeline failure.

Proposed fix
-## {{product_name}} runtime compatibility 
+## {{product_name}} runtime compatibility
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@en/identity-server/7.2.0/docs/deploy/product-compatibility.md` at line 5,
Remove the trailing whitespace at the end of the header line "##
{{product_name}} runtime compatibility" to satisfy MD009/no-trailing-spaces;
edit that markdown header to have no trailing spaces (and quickly scan adjacent
lines in the same block for any other trailing whitespace) so the Markdown lint
passes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@en/identity-server/7.2.0/docs/deploy/product-compatibility.md`:
- Line 5: Remove the trailing whitespace at the end of the header line "##
{{product_name}} runtime compatibility" to satisfy MD009/no-trailing-spaces;
edit that markdown header to have no trailing spaces (and quickly scan adjacent
lines in the same block for any other trailing whitespace) so the Markdown lint
passes.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 4d2f54e2-7474-4526-9d41-a7c4d7255fa3

📥 Commits

Reviewing files that changed from the base of the PR and between de67c8d and 88e8483.

📒 Files selected for processing (2)
  • en/identity-server/7.2.0/docs/deploy/product-compatibility.md
  • en/identity-server/next/docs/deploy/product-compatibility.md

@himeshsiriwardana himeshsiriwardana merged commit e7bf2d2 into wso2:master Apr 12, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants