Fix: Add crucial requirement for custom attributes in OIDC scope for access token inclusion (Product IS issue #27542)#6058
Conversation
…access token inclusion (product-is#27542) Updated the Access Token Attributes documentation to clarify that custom attributes must be explicitly added to an OIDC scope to appear in the access token. This critical detail was missing from the documentation, potentially causing confusion for users. Changes: - Added warning note explaining the requirement to map custom attributes to OIDC scopes - Included instructions on how to configure the scope settings - Applies to versions 7.1.0, 7.2.0, and later versions Co-Authored-By: wso2-engineering-bot <engineering-bot@wso2.com>
|
wso2-engineering-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdded a warning to the Access Token Attributes documentation clarifying that custom attributes are included in JWT access tokens only when they are explicitly mapped to an OIDC scope and the application requests that scope; without such mapping, custom attributes are not present in the JWT. Changes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
en/includes/guides/fragments/manage-app/oidc-settings/access-token.md (1)
57-58:⚠️ Potential issue | 🔴 CriticalFix: Add blank line before heading to resolve pipeline failure.
The Markdown linter requires a blank line above headings. The pipeline is currently failing with MD022 error at line 58.
📝 Proposed fix
{% endif %} + #### Access Token Attributes🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@en/includes/guides/fragments/manage-app/oidc-settings/access-token.md` around lines 57 - 58, Add a blank line immediately before the conditional heading block that renders "#### Access Token Attributes" so the Markdown linter rule MD022 is satisfied; specifically, update the template around the expression {% if product_name == "Asgardeo" or (product_name == "WSO2 Identity Server" and is_version != "7.0.0") %} to ensure there is an empty line preceding the "#### Access Token Attributes" heading when it is rendered.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@en/includes/guides/fragments/manage-app/oidc-settings/access-token.md`:
- Line 67: Remove the trailing whitespace on the blank line in access-token.md
(the blank line reported by the linter) so the line contains no spaces; simply
delete the extra spaces at the end of that empty line to satisfy MD009.
---
Outside diff comments:
In `@en/includes/guides/fragments/manage-app/oidc-settings/access-token.md`:
- Around line 57-58: Add a blank line immediately before the conditional heading
block that renders "#### Access Token Attributes" so the Markdown linter rule
MD022 is satisfied; specifically, update the template around the expression {%
if product_name == "Asgardeo" or (product_name == "WSO2 Identity Server" and
is_version != "7.0.0") %} to ensure there is an empty line preceding the "####
Access Token Attributes" heading when it is rendered.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 91c910ec-27b4-42bd-a818-c16efc99283b
📒 Files selected for processing (1)
en/includes/guides/fragments/manage-app/oidc-settings/access-token.md
en/includes/guides/fragments/manage-app/oidc-settings/access-token.md
Outdated
Show resolved
Hide resolved
en/includes/guides/fragments/manage-app/oidc-settings/access-token.md
Outdated
Show resolved
Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Pavindu Lakshan <pavindulakshan@gmail.com>
This PR was automatically generated by Claude AI.
Changes Made
Affected Versions
This fix applies to the following Identity Server versions:
Note: Version 7.0.0 does not include the Access Token Attributes feature, so this fix does not apply to that version.
Style Scope Verification
Microsoft Style Guidelines have been applied to the newly added content:
Verification
The markdown syntax has been validated and follows repository conventions. The changes use proper MkDocs admonition syntax and maintain consistency with existing documentation style.