Skip to content

add headless as a config#44

Open
wordpressfan wants to merge 1 commit intodevelopfrom
enhancement/add-e2e-headless-config
Open

add headless as a config#44
wordpressfan wants to merge 1 commit intodevelopfrom
enhancement/add-e2e-headless-config

Conversation

@wordpressfan
Copy link
Copy Markdown
Collaborator

Description

When I was playing with tests here I wanted to change this headless option on/off many times so having it as a config will make that easier.

Type of change

Please delete options that are not relevant.

  • Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

It's not groomed and doesn't have an issue, I found it as a quick win PR.

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

@wordpressfan wordpressfan self-assigned this Feb 6, 2024
Khadreal
Khadreal previously approved these changes Feb 6, 2024
@MathieuLamiot MathieuLamiot changed the base branch from trunk to develop August 1, 2024 13:57
@MathieuLamiot MathieuLamiot dismissed Khadreal’s stale review August 1, 2024 13:57

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants