Fix/cnki retry for #1383#1384
Open
Chapoly1305 wants to merge 2 commits intowindingwind:mainfrom
Open
Conversation
Contributor
Author
|
Note, I need someone in china mainland help to test this change. My native IP route me to oversea domain which led to 404. I tried to set with dns resolve to mainland service, but their server seems down. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the resilience of the CNKI translation service by introducing a generic retry mechanism for HTTP requests. The main changes are the addition of a reusable
requestWithRetryhelper and its integration into the token fetching and translation request flows.Reliability improvements:
requestWithRetryhelper function to handle automatic retries for asynchronous operations, improving robustness against transient network errors.processTranslationto userequestWithRetry, retrying failed requests up to two times with exponential backoff.getTokenfunction to userequestWithRetryfor token fetching, adding retries to the token acquisition process.