Refactor BFS, remove FastQueue and Recursive duplicates#1296
Merged
williamfiset merged 5 commits intomasterfrom Mar 16, 2026
Merged
Refactor BFS, remove FastQueue and Recursive duplicates#1296williamfiset merged 5 commits intomasterfrom
williamfiset merged 5 commits intomasterfrom
Conversation
Remove BreadthFirstSearchAdjacencyListIterativeFastQueue (custom IntQueue variant redundant with ArrayDeque) and BreadthFirstSearchRecursive (recursive BFS with queue-passing hack). Refactor the remaining BFS implementation with improved docs, final fields, and cleaner code style. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…AdjacencyList Drop "Iterative" from the class and file name now that the recursive and fast-queue variants have been removed. Replace the 13-node example with a simpler 8-node graph including a visual diagram. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
BFS operates on unweighted graphs, so the cost field and weighted edge helpers are unnecessary. Rename addUnweightedUndirectedEdge to addUndirectedEdge. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use intValue() instead of != to avoid reference comparison failure for node indices >= 128 (outside Integer cache range). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BreadthFirstSearchAdjacencyListIterativeFastQueue.java— customIntQueueis redundant withArrayDequeBreadthFirstSearchRecursive.java— recursive BFS with queue-passing hack, not a true recursive BFSBreadthFirstSearchAdjacencyListIterative.java— add algorithm docs, make fields final, clean up code styleTest plan
bazel test //src/test/java/com/williamfiset/algorithms/graphtheory:BreadthFirstSearchAdjacencyListIterativeTestpassesbazel build //src/main/java/com/williamfiset/algorithms/graphtheory:graphtheorypasses🤖 Generated with Claude Code