Skip to content

fix: generate .d.cts for CJS exports in dual-format packages#1608

Draft
Copilot wants to merge 1 commit intomainfrom
copilot/fix-issue-1603-again
Draft

fix: generate .d.cts for CJS exports in dual-format packages#1608
Copilot wants to merge 1 commit intomainfrom
copilot/fix-issue-1603-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 31, 2026

Packages with "type": "module" emit .d.ts (interpreted as ESM) but no .d.cts for CJS consumers, triggering publint warnings.

Build configs

  • Added dts: { build: false, autoExtension: true } to cjsConfig in scripts/rslib.base.config.ts — rslib now emits .d.cts alongside .d.ts
  • Applied the same to custom CJS lib entries in packages/core/rslib.config.ts and packages/types/rslib.config.ts

Package exports

Split flat types condition into nested import/require across all 8 dual-format packages (cli, core, graph, rspack-plugin, sdk, types, utils, webpack-plugin):

// before
".": {
  "types": "./dist/index.d.ts",
  "import": "./dist/index.js",
  "default": "./dist/index.cjs"
}

// after
".": {
  "import": { "types": "./dist/index.d.ts", "default": "./dist/index.js" },
  "require": { "types": "./dist/index.d.cts", "default": "./dist/index.cjs" }
}

…nditions

Fix publint warning about missing .d.cts in dual module output by:
1. Adding dts generation with autoExtension for CJS configs
2. Splitting package.json exports types into import/require conditions

Agent-Logs-Url: https://github.com/web-infra-dev/rsdoctor/sessions/17585ee1-2fcf-4ef2-b1fe-ee0f1b8fc18e

Co-authored-by: yifancong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants