fix: generate .d.cts for CJS exports in dual-format packages#1608
Draft
fix: generate .d.cts for CJS exports in dual-format packages#1608
Conversation
…nditions Fix publint warning about missing .d.cts in dual module output by: 1. Adding dts generation with autoExtension for CJS configs 2. Splitting package.json exports types into import/require conditions Agent-Logs-Url: https://github.com/web-infra-dev/rsdoctor/sessions/17585ee1-2fcf-4ef2-b1fe-ee0f1b8fc18e Co-authored-by: yifancong <[email protected]>
Copilot created this pull request from a session on behalf of
yifancong
March 31, 2026 11:42
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages with
"type": "module"emit.d.ts(interpreted as ESM) but no.d.ctsfor CJS consumers, triggering publint warnings.Build configs
dts: { build: false, autoExtension: true }tocjsConfiginscripts/rslib.base.config.ts— rslib now emits.d.ctsalongside.d.tspackages/core/rslib.config.tsandpackages/types/rslib.config.tsPackage exports
Split flat
typescondition into nestedimport/requireacross all 8 dual-format packages (cli, core, graph, rspack-plugin, sdk, types, utils, webpack-plugin):