Skip to content

Changed JS file to remove extra padding from gray theme. Added JS to …#1270

Open
magjarvis wants to merge 3 commits into
5.xfrom
magjarvis/issue-1206-list-collection-paragraphs-padding-inconsistent-between-rows
Open

Changed JS file to remove extra padding from gray theme. Added JS to …#1270
magjarvis wants to merge 3 commits into
5.xfrom
magjarvis/issue-1206-list-collection-paragraphs-padding-inconsistent-between-rows

Conversation

@magjarvis
Copy link
Copy Markdown
Contributor

@magjarvis magjarvis commented May 4, 2026

…remove padding on mobile. Updated CSS file to make padding consistent between rows

📝 Description

Provide a short summary that describes how the fix is implemented

Fixes #1206


✅ Peer Review Checklist

Reviewers: Please verify the following before approving.

  • The pull request links to the issue it is addressing in the comment and in the "Development" section of the PR
  • There is a short summary that describes how the fix is implemented
  • Verifying work: Verify that the changes made are addressing the linked issue
  • Accessibility: Changes that might impact accessibility are reviewed to work with keyboard navigation and screen readers
  • Responsive: Layout is tested on desktop, tablet, and mobile screens
  • Config changes: Any configuration updates are tested and verified using the Distribution Update import
  • Security: Output is sanitized (using t(), Twig auto-escaping, etc.). No secrects included (API keys, etc.)
  • Cleanliness: All debug code (ksm(), dpm(), console.log) has been removed.
  • Comments: Complex logic is explained inline.
  • Documentation: Any relevant documentation has been updated (this can be a separate issue if needed)

📸 Screenshots / Video (Optional)

If this is a UI change, please attach a screenshot or a quick screen recording of the change in action.

…remove padding on mobile. Updated CSS file to make padding consistent between rows
@magjarvis magjarvis requested a review from trubach May 4, 2026 16:19
Copy link
Copy Markdown
Contributor

@trubach trubach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magjarvis - I tested out the changes on my localdev with a copy of the drupal.webtheme site, and I'm seeing that the list collection is being compressed into a small column when it's next to the sidebar. I've seen that happen when the width="page" gets applied to an element next to the sidebar. JS to remove that width attribute can be used to fix it.

Screenshot of what I'm seeing

image

@magjarvis magjarvis requested a review from trubach May 14, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List collection paragraphs padding inconsistent between rows

2 participants