Conversation
- define MercedesBenzFleetApi service with 8 RPCs (vehicles, services, compatibility) - define MercedesBenzVehicleSpecApi service with 3 RPCs (images, specification) - add protoc-gen-connect-go to buf.gen.yaml (simple mode) with GOFLAGS fix - implement interface assertions in client.go for both services - migrate all method signatures from Go structs to proto req/resp - update CLI commands to use proto request builders - upgrade to Go 1.26, golangci-lint v2 with --fix and GOFLAGS=-mod=mod
odsod
force-pushed
the
odsod/push-owtstnwurmmq
branch
from
3e166ce to
a3e0643
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MercedesBenzFleetApiproto service with 8 RPCs (vehicles, services, compatibility)MercedesBenzVehicleSpecApiproto service with 3 RPCs (images, specification)protoc-gen-connect-goplugin withsimplemode*Clientimplements bothfleetv1connect.MercedesBenzFleetApiClientandvehiclespecv1connect.MercedesBenzVehicleSpecApiClient--fixandGOFLAGS=-mod=modTest plan
./tools/mage Lint— 0 issues across all modules./tools/mage Test— all tests pass