feat(cli): split credentials into fleet and vehicle-spec types#30
Merged
Conversation
- Replace kitchen-sink `mbz/v1/Credentials` with two domain-specific protos: - `mercedesbenz/fleet/v1/Credentials` (OAuth2 + Kafka config) - `mercedesbenz/vehiclespec/v1/Credentials` (API key) - Split login into `login fleet` (OAuth2) and `login vehicle-spec` (API key) - Kafka `consume-vehicle-signals` reads topic/group from fleet credentials - Set golines max-len to 120 in `.golangci.yml`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mbz/v1/Credentialsproto into two domain-specific types:mercedesbenz/fleet/v1/Credentials— OAuth2 client credentials + Kafka configmercedesbenz/vehiclespec/v1/Credentials— API key onlylogin fleet(OAuth2) andlogin vehicle-spec(API key)consume-vehicle-signalsreads topic/consumer-group from fleet credentials (with flag overrides).golangci.ymlMotivation
1:1 mapping between proto schema and what's stored in each credential secret — fleet and vehicle-spec APIs have distinct auth models and shouldn't share a single type.
Test plan
go build ./... ./cli/... ./cmd/mbz/...— all three modules compilegolangci-lint run— passes clean