feat(cli): use proto-generated Credentials type#29
Merged
Conversation
For auditing and transparency purposes.
- Replace hand-maintained Credentials struct with proto-generated type from new credentials.proto (edition 2023, opaque API) - Make FileStore.Read/Write proto-aware via proto.Message type switch, using protojson for serialization - Credentials file format changes from json tags to protojson field names (already camelCase, so backwards-compatible)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
credentials.protowith SDK credential schema (region, client_id, client_secret, api_key)Credentialsstruct with proto-generated typeFileStoreproto-aware: type-switches onproto.Messageto use protojson, falls back toencoding/jsonfor non-proto typesTest plan
go build ./...passes forcli/module