REMOTE-1727 Surface artifact upload root cause#11386
Draft
jasonkeung wants to merge 2 commits into
Draft
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
jasonkeung
changed the title
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserves the actionable root cause when an artifact upload target request fails, so quota failures surface as an artifact upload limit message instead of only
Failed to create file artifact upload target.Linked Issue
REMOTE-1727
ready-to-specorready-to-implement.Testing
cargo fmt --manifest-path /workspace/warp/Cargo.toml --all -- --checkcargo test --manifest-path /workspace/warp/Cargo.toml -p warp format_upload_artifact_errorI have manually tested my changes locally with
./script/runScreenshots / Videos
Not applicable for this focused error-copy change.
Agent Mode
CHANGELOG-BUG-FIX: Artifact upload failures now surface actionable quota-limit details when upload limits are reached.
Co-Authored-By: Oz oz-agent@warp.dev
Conversation: https://staging.warp.dev/conversation/aa254ad4-a7ab-49b0-95d6-5af18280c54b
Run: https://oz.staging.warp.dev/runs/019e42ff-b61e-73ae-b998-29f13642cd6d
Plans:
This PR was generated with Oz.