Open
Conversation
Contributor
|
they aren't a required check, and they only started failing relatively recently. Generally I prefer to leave such failures active as checks until they've been investigated and fixed. While fastboot increasingly does not matter (we should for instance replace the test with a vite ssr test) we do attempt to monitor support. Going to leave this open for now but preference is to keep it as a failing check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now all the PRs that are opened against main are failing on the fastboot tests, and really "fastboot support" is not a concern of a V2 addon any more
I am proposing that we remove this always failing job for now, and if it's something we want to add back later we can 👍