Skip to content

Holodeck: Change ResponseGenerator to return JSONValue#10429

Open
lucasxzh wants to merge 1 commit intowarp-drive-data:mainfrom
lucasxzh:lucasxzh-holodeck-JSONValue
Open

Holodeck: Change ResponseGenerator to return JSONValue#10429
lucasxzh wants to merge 1 commit intowarp-drive-data:mainfrom
lucasxzh:lucasxzh-holodeck-JSONValue

Conversation

@lucasxzh
Copy link
Copy Markdown
Contributor

@lucasxzh lucasxzh commented Nov 7, 2025 •
edited
Loading

Holodeck should be able to support mocking of servers that aren't following JSON:API spec.

async function registerProjectMessages(ctx: TestContext, id: string) {
  // @ts-expect-error - Holodeck types don't support empty arrays yet? but this should be valid
  await GET(ctx, `projects/${id}/messages`, () => [], { RECORD: true });
}

@lucasxzh
Change ResponseGenerator to return JSONValue
5222ece 
Updated ResponseGenerator type to return JSONValue instead of Record<string, unknown>.

Holodeck should be able to support mocking of servers that aren't following JSON:API spec.
@github-project-automation github-project-automation bot moved this to needs triage in EmberData Nov 7, 2025
@lucasxzh lucasxzh changed the title Change ResponseGenerator to return JSONValue Holodeck: Change ResponseGenerator to return JSONValue Nov 7, 2025
@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature labels Nov 13, 2025
@runspired
Copy link
Copy Markdown
Contributor

runspired commented Nov 13, 2025

needs prettier run but otherwise seems good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@runspired runspired runspired approved these changes

Assignees

No one assigned

Labels

🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucasxzh @runspired