chore: added support for pnpm catalog entries#170
chore: added support for pnpm catalog entries#170stephansama wants to merge 11 commits intovuki656:masterfrom
Conversation
vuki656
left a comment
vuki656
left a comment
There was a problem hiding this comment.
Although this all looks good I'm not a fan of this pnpm specific thing being so tightly coupled in in the main "generic" setup
Specifically stuff in virtual_text.lua. Not sure exactly how i'd like it to work or be laid out. If you're up for it try to refactor so virtual_text does't know about pnpm
If not I'll merge it and play around with it later on
Thanks for the PR
lua/package-info/actions/show.lua
Outdated
| job({ | ||
| json = true, | ||
| command = "npm outdated --json", | ||
| command = has_workspace() and "pnpm outdated --json" or "npm outdated --json", |
There was a problem hiding this comment.
Lets extract this to a fn above/below somewhere now that we need to support 2 cases
| if string.find(value, "catalog:") ~= nil then | ||
| return true | ||
| end |
There was a problem hiding this comment.
Move this to a fn above called is_pnpm_version or something similar since string find for catalog is a bit ambiguous
of course sir! im not the greatest lua programmer hence why i converted my nvim config partially to typescript. but i will do my best to address the requested changes! |
2 participants
add pnpm catalog support
requires a dependency on yq to work properly however i think it is a small dependency for such a cool feature.
addresses this issue