fix(focusTrap): prevent page scroll when capturing focus in overlay#22825
Open
jlee038 wants to merge 1 commit intovuetifyjs:masterfrom
Open
fix(focusTrap): prevent page scroll when capturing focus in overlay#22825jlee038 wants to merge 1 commit intovuetifyjs:masterfrom
jlee038 wants to merge 1 commit intovuetifyjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #22802
When
captureFocusredirects focus into an overlay's content element,focus()was called without{ preventScroll: true }. If the overlay has not yet been positioned byupdateLocation(ResizeObserver, async), the content element is at its default position (top: 0), causing the browser to scroll the page to the top to bring the focused element into view.This is most visible when
transitionis disabled (:transition="false"), because the defaultVDialogTransitionsetsvisibility: hiddenduring the enter animation which normally prevents the browser from scrolling to a hidden element — masking the bug.The fix adds
{ preventScroll: true }to all threefocus()calls inuseFocusTrapbecause focus trap redirections shouldn't cause unintended page scroll. Intentional scrolls are handled elsewhere (e.g.scrollToIndex(),scrollIntoView()).Markup: