Draft
Conversation
|
commit: |
mergeRanges now sorts, merges, and drops invalid (zero-width or inverted) ranges before chunking, applied to both the query and caller-supplied matches paths so unsorted or overlapping input produces correct output. Adds per-symbol @example JSDoc, the tree-shaking side-effects marker, Architecture mermaid + Reactivity section in the docs page, README sync, and tests covering unsorted, overlapping, zero-width, inverted, and out-of-bounds ranges plus reactive query/matches and getter inputs.
ref('foo') for a string primitive violates PHILOSOPHY §4.1 — shallowRef
is the right primitive for booleans, numbers, strings. Examples are
the de facto template for downstream consumers, so the rule has to hold
there too. Codifies the convention in .claude/rules/docs.md so future
example authors see it without needing to read PHILOSOPHY first.
The shallowRef-in-examples rule belongs on master as a project-wide docs convention, not bundled with the toHighlight feature work. Re-landing on master separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new utility meant to replace VHighlight internal logic