Skip to content

Respect no_color#1980

Merged
bastelfreak merged 1 commit intovoxpupuli:masterfrom
bwitt:no-color
Jan 22, 2026
Merged

Respect no_color#1980
bastelfreak merged 1 commit intovoxpupuli:masterfrom
bwitt:no-color

Conversation

@bwitt
Copy link
Copy Markdown
Contributor

@bwitt bwitt commented Jan 4, 2026

Respect the NO_COLOR env var to set no color. Prioritizes BEAKER_COLOR over NO_COLOR.

Fixes #1968

@bastelfreak bastelfreak added the bug label Jan 4, 2026
Comment thread lib/beaker/options/presets.rb Outdated
Comment thread lib/beaker/options/presets.rb Outdated
@bwitt bwitt force-pushed the no-color branch 2 times, most recently from 228d0fd to 1cdd041 Compare January 12, 2026 06:20
@bwitt bwitt requested a review from ekohl January 12, 2026 06:25
Copy link
Copy Markdown
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, but I haven't tried it myself

Comment thread spec/beaker/options/presets_spec.rb Outdated
@ekohl
Copy link
Copy Markdown
Member

ekohl commented Jan 13, 2026

@bastelfreak I see you labeled it as a bug, but I'd argue it's a feature.

@bastelfreak bastelfreak merged commit 6c723f4 into voxpupuli:master Jan 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beaker color output global setting - no_color

3 participants