Add additonal test for `x.crypto.curve25519' module#3
Merged
spytheman merged 1 commit intovlang:mainfrom Jun 20, 2025
Merged
Conversation
|
Originally tests came from |
Contributor
Author
Yeah, the link you give have cited it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains additional tests for
x.crypto.curve25519module. The motivation comes from the talk at Discord.In this PR, the tests basically contains two tests, ie
There are some cases in the test that i think should be handled correctly in the module, likes private key == -1 (mod order) case, private key == 1 (mod order) on twist case.
But, btw, this test was a good addition.
Thanks..and cheers