fix: Not execute _route on preflight requests#1564
Open
ArneGudermann wants to merge 2 commits intoviur-framework:mainfrom
Open
fix: Not execute _route on preflight requests#1564ArneGudermann wants to merge 2 commits intoviur-framework:mainfrom
_route on preflight requests#1564ArneGudermann wants to merge 2 commits intoviur-framework:mainfrom
Conversation
ArneGudermann
added
bug(fix)
phorward
requested changes
Sep 13, 2025
Member
phorward
left a comment
phorward
left a comment
There was a problem hiding this comment.
Hello @ArneGudermann,
I think this solution is wrong, because inside of self._route(), there are several more tests on self.method == "options" which won't be accessible anymore by your change.
Please make a deeper determination of the problem, maybe exceptions must be handled differently in pre-flight requests.
Contributor
Author
|
Okay I think this my fault. In https://fetch.spec.whatwg.org/#cors-protocol-and-credentials it's described that this problem only on CORS request exist. |
phorward
added
Priority: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you call a list with the
x-viur-bonelistheader, the browser starts a preflight request. This request is sent without cookies, so if you have an access check in the list filter, the core response is a 401 error, and the browser thinks it cannot send the header.