fix:Omit query and hash part if both apears in path#590
Open
aliraad79 wants to merge 1 commit intovisionmedia:masterfrom
Open
fix:Omit query and hash part if both apears in path#590aliraad79 wants to merge 1 commit intovisionmedia:masterfrom
aliraad79 wants to merge 1 commit intovisionmedia:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
As mentioned in #575 issue if path have both ?foo=bar and # foo the page.js only removes # foo part
so i fix this in this commit and now the output is:
canonicalPath /foo?hello=there
pathname /foo
canonicalPath /foo#hash
pathname /foo
canonicalPath /foo?hello=there#hash
pathname /foo
It's my first time contributing to this repo so I'm very happy if anyone has a comment on this.
also i run test and everything works fine