fix: don't fail on routes that begin with the page base setting#546
Open
andyburke wants to merge 2 commits intovisionmedia:masterfrom
Open
fix: don't fail on routes that begin with the page base setting#546andyburke wants to merge 2 commits intovisionmedia:masterfrom
andyburke wants to merge 2 commits intovisionmedia:masterfrom
Conversation
Collaborator
|
Thanks for adding a test! It looks like compiling made a whole bunch of changes that were related to your change. Why is that? |
Contributor
Author
|
I honestly don't know. I just tried re-running Is there a way you could pull the branch and try to build and see if the same thing is happening? |
Collaborator
|
Yeah I can do that, probably not until this weekend though. |
Contributor
Author
|
Any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves an issue where if you set the base to something that matches the beginning of one of your routes, things will not work properly. Eg:
page.base( '/en' ); // set to english localizationIf you have a route like '/enroll', this will cause errors.
This change fixes the issue.