Made the sameOrigin call work consistently in IE11.#512
Open
ForBalah wants to merge 1 commit intovisionmedia:masterfrom
Open
Made the sameOrigin call work consistently in IE11.#512ForBalah wants to merge 1 commit intovisionmedia:masterfrom
ForBalah wants to merge 1 commit intovisionmedia:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that in Internet Explorer 11 (this is for a corporate client still on Windows 7), when the host name does not include the port number, (e.g. http://internal.test.com/), then the anchor tag returned by
_toURL()call had a different port number ("80") to the port number fromwindow.location(""). As such, thesameOrigin()call was returning false, resulting in routing not being captured.This was occurring in both http and https sites that did not explicitly include the port number in the url.
I tested this fix in Chrome and Firefox on Windows and it still works there.