fix: convert Tracklist length to a getter and fix event docs#9142
Merged
mister-ben merged 1 commit intovideojs:mainfrom Jan 13, 2026
Merged
fix: convert Tracklist length to a getter and fix event docs#9142mister-ben merged 1 commit intovideojs:mainfrom
mister-ben merged 1 commit intovideojs:mainfrom
Conversation
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
e633327 to
a012ba9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9142 +/- ##
==========================================
- Coverage 84.31% 84.31% -0.01%
==========================================
Files 120 120
Lines 8154 8153 -1
Branches 1964 1964
==========================================
- Hits 6875 6874 -1
Misses 1279 1279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mister-ben
approved these changes
Jan 5, 2026
amtins
approved these changes
Jan 11, 2026
Contributor
|
LGTM |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #9059 by ensuring the length property is properly exposed in the generated TypeScript definition files for
TrackList.Additionally, this PR fixes a typo, and corrects the
@eventtag for thelabelchangeevent handler.Specific Changes proposed
We can convert
lengthto a getter method. By replacing theObject.definePropertycall in the constructor withget length()getter, we can make the property visible to the type generator.After this change, the generated
track-list.d.tswill includeget length(): number;.Requirements Checklist
npm run docs:apito error