fix: Broken menu button setIcon type#9089
Merged
mister-ben merged 2 commits intovideojs:mainfrom Jan 12, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9089 +/- ##
=======================================
Coverage 84.31% 84.31%
=======================================
Files 120 120
Lines 8154 8154
Branches 1964 1964
=======================================
Hits 6875 6875
Misses 1279 1279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Chocobozzz
added a commit
to Chocobozzz/PeerTube
that referenced
this pull request
Sep 12, 2025
Remove the patch when videojs/video.js#9089 is published
mister-ben
approved these changes
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent
Typescript error
Specific Changes proposed
Fix typings
Requirements Checklist
npm run docs:apito error