Skip to content

fix: update release workflow discussion permission#9031

Merged
Essk merged 1 commit intomainfrom
fix-release-workflow
Apr 16, 2025
Merged

fix: update release workflow discussion permission#9031
Essk merged 1 commit intomainfrom
fix-release-workflow

Conversation

@Essk
Copy link
Copy Markdown
Contributor

@Essk Essk commented Apr 16, 2025

Description

#9027 only fixed one issue with the release workflow. The last release run failed with:

👩‍🏭 Creating new GitHub release for tag v8.23.2...
⚠️ GitHub release failed with status: 404
undefined
retrying... (2 retries remaining)
👩‍🏭 Creating new GitHub release for tag v8.23.2...
⚠️ GitHub release failed with status: 422
[{"resource":"Release","code":"already_exists","field":"tag_name"}]

The initial 404 appears to have be caused by a lack of permission for discussions, and then subsequent tries fail because the tag already exists.

Specific Changes proposed

Add write permission for discussions

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (ac523ed) to head (e525889).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9031   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files         120      120           
  Lines        8154     8154           
  Branches     1964     1964           
=======================================
  Hits         6875     6875           
  Misses       1279     1279           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Essk Essk merged commit 1a09554 into main Apr 16, 2025
13 checks passed
@Essk Essk deleted the fix-release-workflow branch April 16, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants