Skip to content

fix: only change focus from BPB if not tap or mouse click #9015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Essk merged 2 commits into from
Apr 15, 2025
+2 −2
Merged

fix: only change focus from BPB if not tap or mouse click #9015

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0940ae9
Only change focus from BPB if not tap or mouse click
Frenzie Mar 20, 2025
970abcf
Merge branch 'main' into 9006-ignore-tap-for-big-play-button-focus
Essk Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/js/big-play-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@
handleClick(event) {
const playPromise = this.player_.play();

// exit early if clicked via the mouse
if (this.mouseused_ && 'clientX' in event && 'clientY' in event) {
// exit early if tapped or clicked via the mouse
if (event.type === 'tap' || this.mouseused_ && 'clientX' in event && 'clientY' in event) {

Check warning on line 50 in src/js/big-play-button.js

View check run for this annotation

Codecov / codecov/patch

src/js/big-play-button.js#L50 

Added line #L50 was not covered by tests
silencePromise(playPromise);

if (this.player_.tech(true)) {
Expand Down