[otel] honor traceparent for verbose mode spans#93874
Open
kakadiadarpan wants to merge 1 commit into
Open
Conversation
kakadiadarpan
changed the title
kakadiadarpan
force-pushed
the
darpan/fix-otel-traceparent-verbose
branch
from
390e4ee to
6597534
Compare
kakadiadarpan
force-pushed
the
darpan/fix-otel-traceparent-verbose
branch
from
6597534 to
05f4ad9
Compare
kakadiadarpan
requested review from
devjiwonchoi,
ijjk and
ztanner
and removed request for
ztanner
Contributor
Tests PassedCommit: 05f4ad9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes the trace propagation issue reported in vercel/otel#107.
NEXT_OTEL_VERBOSE=1opened theNextServer.getRequestHandlerspan before request header propagation, so incomingtraceparentwas ignored and framework spans started a new trace.Solution
Extract propagated request context before wrapper request-handler spans. Add focused e2e coverage in the existing OpenTelemetry suite for verbose spans inheriting the incoming
traceparent, including the parent span id.Validated with
pnpm --filter=next buildandpnpm test-dev-turbo test/e2e/opentelemetry/instrumentation/opentelemetry.test.ts.