Fix for IMAGEMAGICK_FIT_WITH_BLUR command#838
Merged
jlu5 merged 1 commit intovarietywalls:masterfrom May 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For quite a while I noticed the "Fit within screen, pad with a blurred background" option was broken on my system.
It generated a fully blurred image without the original overlaid on top.
Looking at the git blame I see no changes there, so maybe it was a change in imagemagick itself.
Looking at my logs, this was the imagemagick command, that when run isolated was in fact generating the fully blurred image:
This is the new command, that works as expected:
Surprised I didn't see any bug reports related to this. Even if this is isolated to Debian testing or whatever, the new imagemagick command is more explicit and shouldn't break any system.
Here is a image comparing the two outputs for a portrait image, one where Variety's auto-mode would choose "Fit within screen, pad with a blurred background" fitting.
Disclaimer: The imagemagick command was partially generated by a LLM, but from my review seems correct and straightforward enough (I'd argue simpler than the original).