Skip to content

Env: Read VALKEYCLI_HOST and VALKEYCLI_PORT environment variables #3402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dietr1ch wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

Env: Read VALKEYCLI_HOST and VALKEYCLI_PORT environment variables #3402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/valkey-cli.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@
#define CLI_RCFILE_DEFAULT ".valkeyclirc"
#define CLI_AUTH_ENV "VALKEYCLI_AUTH"
#define OLD_CLI_AUTH_ENV "REDISCLI_AUTH"
#define CLI_HOST_ENV "VALKEYCLI_HOST"
#define CLI_PORT_ENV "VALKEYCLI_PORT"
#define CLI_CLUSTER_YES_ENV "VALKEYCLI_CLUSTER_YES"
#define OLD_CLI_CLUSTER_YES_ENV "REDISCLI_CLUSTER_YES"

Expand Down Expand Up @@ -2931,6 +2933,14 @@ static void parseEnv(void) {
if (auth != NULL && config.conn_info.auth == NULL) {
config.conn_info.auth = auth;
}
char *host = getenv(CLI_HOST_ENV);
if (host != NULL) {
config.conn_info.hostip = sdsnew(host);
}
char *port = getenv(CLI_PORT_ENV);
if (port != NULL) {
config.conn_info.hostport = atoi(port);
}

/* Check for cluster yes flag with fallback to legacy env variable */
char *cluster_yes = getenv(CLI_CLUSTER_YES_ENV);
Expand Down