Skip to content

feat: Add Fullscreen API wrapping the browser Fullscreen API #23616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Artur- wants to merge 2 commits into
base: main
Choose a base branch
from

Merge branch 'main' into fullscreen-api

9c45b6f
Select commit
Loading
Failed to load commit list.
Draft

feat: Add Fullscreen API wrapping the browser Fullscreen API #23616

Merge branch 'main' into fullscreen-api
9c45b6f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 9, 2026 in 1m 16s

Quality Gate passed

Issues
1310 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 1115 in flow-server/src/test/java/com/vaadin/flow/dom/ElementTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyL-3PgK2u6WZEDhP&open=AZzRyL-3PgK2u6WZEDhP&pullRequest=23616

Check warning on line 1010 in flow-server/src/test/java/com/vaadin/flow/dom/ElementTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyL-3PgK2u6WZEDjA&open=AZzRyL-3PgK2u6WZEDjA&pullRequest=23616

Check warning on line 146 in flow-server/src/test/java/com/vaadin/flow/component/page/PageTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "retrieveExtendedClientDetails"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZyBJnmFQw9G4jT5zlep&open=AZyBJnmFQw9G4jT5zlep&pullRequest=23616

Check warning on line 2536 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyL2ZPgK2u6WZEDdD&open=AZzRyL2ZPgK2u6WZEDdD&pullRequest=23616

Check warning on line 1777 in flow-server/src/test/java/com/vaadin/flow/dom/ElementTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated class, it has been marked for removal. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyL-3PgK2u6WZEDj-&open=AZzRyL-3PgK2u6WZEDj-&pullRequest=23616

Check warning on line 503 in flow-data/src/test/java/com/vaadin/flow/data/binder/BinderSignalTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyJ8dPgK2u6WZEDU8&open=AZzRyJ8dPgK2u6WZEDU8&pullRequest=23616

Check warning on line 348 in flow-server/src/test/java/com/vaadin/flow/dom/ElementTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyL-3PgK2u6WZEDgd&open=AZzRyL-3PgK2u6WZEDgd&pullRequest=23616

Check warning on line 2036 in flow-server/src/test/java/com/vaadin/flow/component/ComponentTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZyBJpJkQw9G4jT5zlgd&open=AZyBJpJkQw9G4jT5zlgd&pullRequest=23616

Check warning on line 116 in flow-data/src/test/java/com/vaadin/flow/data/provider/HasDataProviderBindItemsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyLmnPgK2u6WZEDVn&open=AZzRyLmnPgK2u6WZEDVn&pullRequest=23616

Check warning on line 402 in flow-server/src/test/java/com/vaadin/flow/server/communication/UidlWriterTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "textValue"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyLnPPgK2u6WZEDWC&open=AZzRyLnPPgK2u6WZEDWC&pullRequest=23616

Check warning on line 89 in flow-data/src/test/java/com/vaadin/flow/data/provider/HasDataProviderBindItemsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyLmnPgK2u6WZEDVl&open=AZzRyLmnPgK2u6WZEDVl&pullRequest=23616

Check warning on line 2344 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyL2ZPgK2u6WZEDcz&open=AZzRyL2ZPgK2u6WZEDcz&pullRequest=23616

Check warning on line 2240 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated class, it has been marked for removal. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyL2aPgK2u6WZEDfQ&open=AZzRyL2aPgK2u6WZEDfQ&pullRequest=23616

Check warning on line 95 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyL2ZPgK2u6WZEDaj&open=AZzRyL2ZPgK2u6WZEDaj&pullRequest=23616

Check warning on line 124 in flow-server/src/test/java/com/vaadin/flow/dom/StyleBindTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyLzdPgK2u6WZEDaC&open=AZzRyLzdPgK2u6WZEDaC&pullRequest=23616

Check warning on line 1895 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated class, it has been marked for removal. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyL2aPgK2u6WZEDe0&open=AZzRyL2aPgK2u6WZEDe0&pullRequest=23616

Check warning on line 479 in flow-server/src/test/java/com/vaadin/flow/dom/ElementBindPropertyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyMEcPgK2u6WZEDlP&open=AZzRyMEcPgK2u6WZEDlP&pullRequest=23616

Check warning on line 1433 in flow-server/src/test/java/com/vaadin/flow/dom/ElementTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyL-3PgK2u6WZEDhr&open=AZzRyL-3PgK2u6WZEDhr&pullRequest=23616

Check warning on line 2035 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Swap these 2 arguments so they are in the correct order: expected value, actual value. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyL2aPgK2u6WZEDfJ&open=AZzRyL2aPgK2u6WZEDfJ&pullRequest=23616

Check warning on line 1380 in flow-server/src/test/java/com/vaadin/flow/component/ComponentTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZyBJpJkQw9G4jT5zlgB&open=AZyBJpJkQw9G4jT5zlgB&pullRequest=23616

Check warning on line 1995 in flow-server/src/test/java/com/vaadin/flow/dom/ElementTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Swap these 2 arguments so they are in the correct order: expected value, actual value. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyL-3PgK2u6WZEDkf&open=AZzRyL-3PgK2u6WZEDkf&pullRequest=23616

Check warning on line 188 in flow-server/src/test/java/com/vaadin/flow/component/SignalPropertySupportTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyLxtPgK2u6WZEDZT&open=AZzRyLxtPgK2u6WZEDZT&pullRequest=23616

Check warning on line 1595 in flow-server/src/test/java/com/vaadin/flow/dom/ElementTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyL-3PgK2u6WZEDh3&open=AZzRyL-3PgK2u6WZEDh3&pullRequest=23616

Check warning on line 1804 in flow-server/src/test/java/com/vaadin/flow/dom/ElementTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.net.URISyntaxException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyL-3PgK2u6WZEDkD&open=AZzRyL-3PgK2u6WZEDkD&pullRequest=23616

Check warning on line 774 in flow-server/src/test/java/com/vaadin/flow/server/StaticFileServerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZzRyLpxPgK2u6WZEDWx&open=AZzRyLpxPgK2u6WZEDWx&pullRequest=23616
View more details on SonarQubeCloud