[rls-v3.12] build: exclude Xe3p from default DNNL_ENABLE_PRIMITIVE_GPU_ISA#5105
[rls-v3.12] build: exclude Xe3p from default DNNL_ENABLE_PRIMITIVE_GPU_ISA#5105
Conversation
github-actions
Bot
added
documentation
|
|
||
| #if BUILD_PRIMITIVE_GPU_ISA_ALL || BUILD_XE3P | ||
| // XE3P is excluded from BUILD_PRIMITIVE_GPU_ISA_ALL, opt in explicitly. | ||
| #if BUILD_XE3P |
There was a problem hiding this comment.
Do we need any gating on OpenCL implementations? For the most part, I would expect those to just work, but there are some workarounds for driver issues.
There was a problem hiding this comment.
We don't have any control on driver version at the user end, so I'd say no.
| # Use oneDNN names for ALL to ensure string replacement functions correctly | ||
| set(GPUS ${DNNL_ENABLE_PRIMITIVE_GPU_ISA}) | ||
| string(REPLACE "ALL" "XELP;XEHP;XEHPG;XEHPC;XE2;XE3;XE3P" GPUS "${GPUS}") | ||
| string(REPLACE "ALL" "XELP;XEHP;XEHPG;XEHPC;XE2;XE3" GPUS "${GPUS}") |
There was a problem hiding this comment.
Would it be reasonable to use a runtime guard (via environment variable) rather than compile time? This way we can still use the same build for testing purpose.
There was a problem hiding this comment.
From my perspective runtime opt-in is the best choice. It would be challenging to design and implement it in time for v3.12 RTM.
There was a problem hiding this comment.
What we can do before the RTM is opt-in via ONEDNN_ENABLE_MAX_GPU_ISA environment variable (similar to CPU). But to limit the scope:
- No API, just the environment variable
- Opt-in is only via the environment variable - no changes in
DNNL_ENABLE_PRIMITIVE_GPU_ISAbehavior
@vpirogov @rjoursler Do you see issues with any of the bullets? Are frameworks fine with environment variable control for opt-in (if they still want to enable Xe3p platforms)?
There was a problem hiding this comment.
I would rather focus on developing proper guard consistent with the way we handle environment variables for v3.13. Build time opt-in looks adequate for v3.12.
|
make test |
|
make test |
4 participants
For background see MFDNN-15003.
Opening a PR to discuss and to map out potential side effects of making Xe3p support opt-in.