Add Isar output mode#1391
Draft
edoput wants to merge 36 commits intoutwente-fmt:devfrom
Draft
Conversation
Contributor
|
I converted your PR into a draft one. Feel free to un-draft it once you're planning on merging it soon. |
superaxander
requested changes
Jan 8, 2026
Member
superaxander
left a comment
superaxander
left a comment
There was a problem hiding this comment.
I have two small comments
this commit adds a print mode to output Isar syntax
fold is defined as foldl which is left associative but I need the right associative version for printing function types in ML
edoput
force-pushed
the
dev
branch
2 times, most recently
from
24b7200 to
0cbe14d
Compare
added 2 commits
April 16, 2026 14:29
also use the correct symbol for the cardinality
Member
superaxander
left a comment
superaxander
left a comment
There was a problem hiding this comment.
Looks good, please look at the comments I made and mark the PR as ready to review when you want it merged
| import vct.col.ast.family.pvlcommunicate._ | ||
| import vct.col.ast.family.seqrun._ | ||
| import vct.col.ast.family.signals._ | ||
| import vct.col.ast.lang.Isar.{ |
Member
There was a problem hiding this comment.
Replace with _ import please
| val result = Parsing.ofOptions(options, blameProvider) | ||
| .thenRun(Resolution.ofOptions(options, blameProvider)) | ||
| .thenRun(Transformation.isarOfOptions(options)).thenRun(Output( | ||
| options.isarOutput.orElse(Some(Paths.get("a.java"))), |
Member
There was a problem hiding this comment.
I guess this should be different default file name
added 4 commits
April 22, 2026 14:11
ADTs are translated to locales so we need to bind the lexical scope of locales to the lexical scope of ADTs. Moreover in the interpretation command we require the full list of parameters to the locales hierarchy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
PR description
This PR introduces a syntactic transformation from PVL to Isabelle. This allows for translating PVL's ADTs to a locale to prove they are consistent. The transformation is available as a command from vct, see example.
This creates a new file
foo.thypre-filled with a locale for each ADT. The user can then provide a witness for each locale to prove the corresponding ADT consistent.