Skip to content

feat(server): add base option to h3 handler #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snarcraft wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

feat(server): add base option to h3 handler #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ const ipx = createIPX({
httpStorage: ipxHttpStorage({ domains: ["picsum.photos"] }),
});

const app = createApp().use("/", createIPXH3Handler(ipx));
const base = '/'

const app = createApp().use(base, createIPXH3Handler(ipx, { base }));

listen(toNodeListener(app));
```
Expand Down
6 changes: 3 additions & 3 deletions src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ import { IPX } from "./ipx";
const MODIFIER_SEP = /[&,]/g;
const MODIFIER_VAL_SEP = /[:=_]/;

export function createIPXH3Handler(ipx: IPX) {
export function createIPXH3Handler(ipx: IPX, options = { base: "/" }) {
const _handler = async (event: H3Event) => {
// Parse URL
const [modifiersString = "", ...idSegments] = event.path
.slice(1 /* leading slash */)
.replace(options.base, "")
.split("/");

const id = safeString(decode(idSegments.join("/")));
Expand All @@ -47,7 +47,7 @@ export function createIPXH3Handler(ipx: IPX) {
});
}

// Contruct modifiers
// Construct modifiers
const modifiers: Record<string, string> = Object.create(null);

// Read modifiers from first segment
Expand Down