Fix VerifyToken compilation under OTP 28 by allowing binary scheme_reg#739
Merged
yordis merged 1 commit intoueberauth:masterfrom Aug 4, 2025
Merged
Conversation
yordis
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with the new regex implementation in OTP28 causing Guardian.Plug.VerifyHeader not to compile (See #737 )
I could make out this Regex.compile call as the source of the problem.
Allowing
opts[:scheme_reg]to be a string and callingRegex.compilelater seems to make it work while also keeping changes to a minimum.I wanted to share a possible solution should it be useful. I am not sure how elegant a solution this really is and problems with jose will keep the current state of being fully compatible with OTP28 at the moment.