Feature/data library#1686
Open
k-burt-uch wants to merge 10 commits intomasterfrom
Open
Conversation
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
mfshao
reviewed
Apr 28, 2025
|
|
||
| .discovery-action-section { | ||
| display: flex; | ||
| flex-direction: row; |
Collaborator
There was a problem hiding this comment.
do we need this? there is only one element in that div
| if (currentList) { | ||
| saveToList(currentList.label, currentList.value); | ||
| } else { | ||
| saveToList(currentList.label); |
Collaborator
There was a problem hiding this comment.
currentList might be null or undefined here?
| const mapStateToProps = (state) => ({ | ||
| user: state.user, | ||
| discovery: state.discovery, | ||
| systemPopupActivated: !!state.popups?.systemUseWarnPopup, |
Collaborator
There was a problem hiding this comment.
why we need this props for data library?
| disabled={error !== null || loading || data?.length === 0 || currentList === undefined || selectedResources.length === 0 || notLoggedIn} | ||
| onClick={() => { | ||
| if (currentList) { | ||
| saveToList(currentList.label, currentList.value); |
Collaborator
There was a problem hiding this comment.
should we call fetchLists() after this? Otherwise if I'm creating a new list, the list ID will remains undefined until I refresh the page 🤔
| @@ -0,0 +1,183 @@ | |||
| import React, { | |||
Collaborator
There was a problem hiding this comment.
wish we could have a story for this component in storybook
| - https://*.quicksight.aws.amazon.com for loading AWS Quicksight dashboards into COVID-19 Home page | ||
| --> | ||
| <meta http-equiv="Content-Security-Policy" content="default-src 'self' https://login.bionimbus.org https://wayf.incommonfederation.org; child-src blob:; img-src 'self' <%= htmlWebpackPlugin.options.imgSrc %> https://opendata.datacommons.io https://static.planx-pla.net data: https://*.s3.amazonaws.com blob:; script-src 'self' 'unsafe-eval' <%= htmlWebpackPlugin.options.scriptSrc %>; worker-src 'self' blob:; style-src 'self' 'unsafe-inline' https://fonts.googleapis.com; object-src 'none'; font-src 'self' data: https://fonts.googleapis.com https://fonts.gstatic.com; connect-src 'self' https://login.bionimbus.org https://wayf.incommonfederation.org https://opendata.datacommons.io https://static.planx-pla.net https://*.zendesk.com <%= htmlWebpackPlugin.options.connectSrc %>; frame-src <%= htmlWebpackPlugin.options.connectSrc %> 'self' https://auspice.planx-pla.net https://auspice.pandemicresponsecommons.org https://*.quicksight.aws.amazon.com;"> | ||
| <meta http-equiv="Content-Security-Policy" content="default-src 'self' http://localhost:8000 https://login.bionimbus.org https://wayf.incommonfederation.org; child-src blob:; img-src 'self' <%= htmlWebpackPlugin.options.imgSrc %> http://localhost:8000 https://opendata.datacommons.io https://static.planx-pla.net data: https://*.s3.amazonaws.com blob:; script-src 'self' 'unsafe-eval' <%= htmlWebpackPlugin.options.scriptSrc %>; worker-src 'self' blob:; style-src 'self' 'unsafe-inline' https://fonts.googleapis.com; object-src 'none'; font-src 'self' data: https://fonts.googleapis.com https://fonts.gstatic.com; connect-src 'self' https://login.bionimbus.org https://wayf.incommonfederation.org https://opendata.datacommons.io https://static.planx-pla.net https://*.zendesk.com <%= htmlWebpackPlugin.options.connectSrc %>; frame-src <%= htmlWebpackPlugin.options.connectSrc %> 'self' https://auspice.planx-pla.net https://auspice.pandemicresponsecommons.org https://*.quicksight.aws.amazon.com;"> |
Collaborator
There was a problem hiding this comment.
is this for local testing? if so I suggest moving them to dev.html and only use them from there
| scriptSrcURLs.push(...['https://www.google-analytics.com', 'https://ssl.google-analytics.com', 'https://www.googletagmanager.com']); | ||
| connectSrcURLs.push(...['https://www.google-analytics.com', 'https://*.analytics.google.com', 'https://analytics.google.com', 'https://*.g.doubleclick.net']); | ||
| scriptSrcURLs.push(...['http://localhost:8000', 'http://www.google-analytics.com','https://www.google-analytics.com', 'https://ssl.google-analytics.com', 'https://www.googletagmanager.com']); | ||
| connectSrcURLs.push(...['http://localhost:8000', 'https://*.analytics.google.com', 'https://analytics.google.com', 'https://*.g.doubleclick.net']); |
Collaborator
There was a problem hiding this comment.
I don't think you need to do them here with google analytics
| <Button | ||
| loading={loading} | ||
| type='primary' | ||
| disabled={error !== null || loading || data?.length === 0 || currentList === undefined || selectedResources.length === 0 || notLoggedIn} |
Contributor
There was a problem hiding this comment.
data?.length === 0 seems to prevent any initial list creation. It does not seem to increase when a user's first list is initially entered (after creation, but before a study is Saved to list), and subsequently can't be Saved to List as the button remains disabled. I have tested removing this and it resolves this issue
Please find the detailed integration test report here Login here Please find the ci env pod logs here |
Please find the detailed integration test report here (login here first) |
k-burt-uch
force-pushed
the
feature/data_library
branch
from
a81f1d8 to
e7192e9
Compare
Please find the detailed integration test report here (login here first) |
add notifications with icons add doc for enableDataLibrary
k-burt-uch
force-pushed
the
feature/data_library
branch
from
e7192e9 to
bd45089
Compare
Please find the detailed integration test report here |
Please find the detailed integration test report here Please find the Github Action logs here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes