Open
Conversation
Since we are planning to use the files from the directory as-is might as well update them to match the modern auto-generated artifacts. https://github.com/LineageOS/android_build/blob/lineage-21.0/core/Makefile#L2476-L2542 Change-Id: I3dcbcd85e5470f9529c0cb1dddfa5c691866fd70
We don't select the recovery DPI to be used via Android build system so point these to the right files and just choose the whole dir externally. https://github.com/LineageOS/android_build/blob/lineage-21.0/core/Makefile#L2466-L2473 Change-Id: I1a5c988d434861f4ddda2f2991d664b9bbd8c10e
JamiKettunen
force-pushed
the
resource-updates
branch
from
c89ac87 to
45a9b1c
Compare
Contributor
|
No objections in general, but would that require us to regenerate the images on each rebase so that the language set matches? Another option is to include all the resource variants into |
Collaborator
|
Is this the approach to go? If so, I'll happily merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for usage externally in per-port UI DPI selection while having a common source for these here.
For integration side counterpart see https://gitlab.com/ubports/porting/community-ports/halium-generic-adaptation-build-tools/-/merge_requests/70