Skip to content

v6: accordions - hide default WebKit details marker (old Safari)#42401

Merged
mdo merged 1 commit into
twbs:v6-devfrom
coliff:dev/coliff/v6-accordion-safari-disclosure-fix
May 15, 2026
Merged

v6: accordions - hide default WebKit details marker (old Safari)#42401
mdo merged 1 commit into
twbs:v6-devfrom
coliff:dev/coliff/v6-accordion-safari-disclosure-fix

Conversation

@coliff
Copy link
Copy Markdown
Contributor

@coliff coliff commented May 8, 2026

Description / Motivation & Context

Suppress the native disclosure marker in WebKit by adding &::-webkit-details-marker { display: none; } to the accordion button styles. This prevents the browser's default triangle from overlapping the custom .accordion-icon and ensures consistent appearance across browsers

Issue discovered using Browserstack.
See comment: https://github.com/orgs/twbs/discussions/42398#discussion-10018925

Improves design on older Safari versions.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Screenshot of deploy preview (Safari 16.5):

image

Suppress the native disclosure marker in WebKit by adding &::-webkit-details-marker { display: none; } to the accordion button styles. This prevents the browser's default triangle from overlapping the custom .accordion-icon and ensures consistent appearance across browsers

Issue discovered using Browserstack.
See comment: https://github.com/orgs/twbs/discussions/42398#discussion-10018925
Copilot AI review requested due to automatic review settings May 8, 2026 00:54
@coliff coliff requested a review from a team as a code owner May 8, 2026 00:54
@coliff coliff changed the title v6: accordions - hide default WebKit details marker v6: accordions - hide default WebKit details marker (Safari) May 8, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a Safari/WebKit rendering issue in the v6 accordion by suppressing the native <summary> disclosure marker so it doesn’t overlap Bootstrap’s custom .accordion-icon, improving cross-browser visual consistency (notably on older Safari versions).

Changes:

  • Add a WebKit-specific rule to hide the default details/summary marker in .accordion-header.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mdo mdo added this to v6.0.0 May 8, 2026
@github-project-automation github-project-automation Bot moved this to Inbox in v6.0.0 May 8, 2026
@mdo
Copy link
Copy Markdown
Member

mdo commented May 8, 2026

Curious what version of Safari you're looking at?

@coliff
Copy link
Copy Markdown
Contributor Author

coliff commented May 8, 2026

Curious what version of Safari you're looking at?

I posted in the linked discussion. It’s safari 17.3 and older it’s broken in. Screenshot above is 16.5 with the fix.

I updated the pr title to say (old safari) :-)

@coliff coliff changed the title v6: accordions - hide default WebKit details marker (Safari) v6: accordions - hide default WebKit details marker (old Safari) May 8, 2026
@mdo mdo merged commit 2599a61 into twbs:v6-dev May 15, 2026
15 of 16 checks passed
@coliff coliff deleted the dev/coliff/v6-accordion-safari-disclosure-fix branch May 15, 2026 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

3 participants