This repository was archived by the owner on Sep 25, 2021. It is now read-only.
Update the visitable titles example code#118
Open
dwightwatson wants to merge 1 commit intoturbolinks:masterfrom
dwightwatson:patch-1
Open
Update the visitable titles example code#118dwightwatson wants to merge 1 commit intoturbolinks:masterfrom dwightwatson:patch-1
dwightwatson wants to merge 1 commit intoturbolinks:masterfrom
dwightwatson:patch-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implementing this code in Xcode I had to mark
visitableDidRenderas an override so figured that belonged in the example code too. Also aswebViewis optional it meansformatTitleneeds to handle that case, so I've added a guard clause example.