Open
Conversation
Contributor
Author
|
@JaydenBLi This PR is good to go but can you rebase the branch so it can merge to main. |
AskewParity
requested changes
Apr 14, 2026
AskewParity
requested changes
Apr 17, 2026
| setNumLaps(data.split(",")[1]); | ||
| } | ||
| } catch (error) { | ||
| console.error("Error fetching tick state:", error); |
Contributor
There was a problem hiding this comment.
can you delete this console.error (I don't think we care about this if it fails).
| const [numLaps, setNumLaps] = useState(67); | ||
| //</Garbage that I wrote> | ||
|
|
||
| const [numLaps, setNumLaps] = useState("-1"); |
Contributor
There was a problem hiding this comment.
This should be initialized to empty string, or keep it consistent with the error message below (change either, I prefer -1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding PR: tritonuas/obcpp#357
Added a new display on the left sidebar of the control page, displays the current lap as well as the total laps.
Fetches from obcstate containing both the information of tickstate and laps, and splits the information accordingly.
If there is an issue or an error with tickstate, there will likely be an issue with numlaps as well.