Pluralize the root wrap from "song" to "songs"#111
Open
chadwtaylor wants to merge 1 commit intotrailblazer:jsonapifrom
chadwtaylor:patch-5
Open
Pluralize the root wrap from "song" to "songs"#111chadwtaylor wants to merge 1 commit intotrailblazer:jsonapifrom chadwtaylor:patch-5
chadwtaylor wants to merge 1 commit intotrailblazer:jsonapifrom
chadwtaylor:patch-5
Conversation
Refer to the jsonapi.org docs, it looks like the root wrap to be pluralized at all times. Another thing, I thought the purpose of this test is to test the use of `render json:singers` but `respond_with` is being used instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to the jsonapi.org docs, it looks like the root wrap to be pluralized at all times.
Another thing, I thought the purpose of this test is to test the use of
render json:singersbutrespond_withis being used instead?